Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple theme and builder #94

Closed
wants to merge 1 commit into from
Closed

Decouple theme and builder #94

wants to merge 1 commit into from

Conversation

j123b567
Copy link
Contributor

Decouple the theme from the builder completely

Alternate approach to #91

@j123b567 j123b567 mentioned this pull request Nov 13, 2023
Open
@danwos
Copy link
Member

danwos commented Nov 13, 2023

Thanks for the PR and for cleaning the code.

This is indeed more structured than the current solution and makes sense.
However, one drawback is that scss-compilation is no embedded feature of Sphinx-SimplePDF anymore, and each theme has to deal with it on its own. But I guess that's fine and our source-code can be simply copied.

@j123b567 j123b567 force-pushed the feature/decouple-theme branch from 4ae1d7c to 6e52450 Compare November 14, 2023 08:34
@j123b567
Copy link
Contributor Author

j123b567 commented Nov 14, 2023 •
edited
Loading

Closing in favor of #91

@j123b567 j123b567 closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwos danwos danwos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j123b567 @danwos