🔧 Deprecate use of dynamic functions in need type fields #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1406 +/- ##
==========================================
+ Coverage 86.87% 88.22% +1.34%
==========================================
Files 56 60 +4
Lines 6532 7153 +621
==========================================
+ Hits 5675 6311 +636
+ Misses 857 842 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It is unintended and unlikely the dynamic functions would have been used in there fields, but just in case we issue a warning of the deprecation, so that we can remove them in the future fields affected: `type`, `type_name`, `type_prefix`, `type_color`, `type_style`. --- Note, there are still maybe some outstanding questions about where dynamic functions should be processed: - should they be processed fo the need title? - should they be processed at all for needs coming from external and/or needimport `needs.json`?
chrisjsewell
force-pushed
the
df-deprecate
branch
from
8ef9e67 to
c75d579
Compare
danwos
approved these changes
Feb 19, 2025
|
I would keep dynamic function evaluation for the For imported and external needs, I think they should not be evaluated. The needs.json producer is in charge of providing non-dynamic field values. It also does not make sense to apply project-local dynamic functions to fields of foreign projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unintended and unlikely the dynamic functions would have been used in there fields, but just in case we issue a warning of the deprecation, so that we can remove them in the future
fields affected:
type,type_name,type_prefix,type_color,type_style.this follows on from #1387 and the fields now allowed are:
titlestatustagsstyleconstraintsneeds_extra_optionsneeds_extra_linksneeds_global_optionsNote, there are still maybe some outstanding questions about where dynamic functions should be processed:
needs.json?