buildkitd: add logs to track boot info

[adityamaru]

Important

Add logging to buildkitd to track boot process times for locks, listeners, controllers, and workers.

• Logging Enhancements:
  • Add log statements in main.go to track time for acquiring lock, setting up listeners, and initializing controllers.
  • Add log statements in main_containerd_worker.go to track time for applying flags, setting up runtime, and initializing workers.
• Specific Log Additions:
  • Log time before and after acquiring lock in main.go.
  • Log time before and after setting up listeners and controllers in main.go.
  • Log time before and after applying containerd flags, setting up runtime, and initializing worker options in main_containerd_worker.go.

^{This description was created by for fd13b85. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to fd13b85 in 15 seconds

More details

• Looked at 147 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. cmd/buildkitd/main.go:258

• Draft comment:
  Consider using Debug log level for the newly added log messages to avoid verbosity in production environments. This applies to all similar log messages in this PR.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The log messages added in this PR are useful for tracking the time taken for various operations. However, the log level used for these messages is Info, which might not be appropriate for all environments. In production, these logs could be too verbose. A better approach would be to use the Debug log level for these messages, as they are primarily useful for debugging purposes.

Workflow ID: wflow_eeynw19YMPtiDp3Q

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[aayushshah15]

Do we plan on merging this still, or are we waiting to see if the version bump just fixes our issues?

[adityamaru]

No there's no plan to merge this and fork once the buildkit version is bumped Sent via Superhuman iOS ( ***@***.*** )

…

On Wed, Dec 25 2024 at 3:32 PM, Aayush Shah < ***@***.*** > wrote: Do we plan on merging this still, or are we waiting to see if the version bump just fixes our issues? — Reply to this email directly, view it on GitHub ( #1 (comment) ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/ADJSIRVOCJ4XNUTU2QAPBS32HMI7XAVCNFSM6AAAAABUDWVWXWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRRHE4TINJZGM ). You are receiving this because you authored the thread. Message ID: <useblacksmith/buildkit/pull/1/c2561994593 @ github. com>