Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: ignore unset sentinel value for tailscale token #89

Conversation

aayushshah15
Copy link

@aayushshah15 aayushshah15 commented Jan 1, 2025

Important

Skip tailnet join in joinTailnet() if BLACKSMITH_TAILSCALE_TOKEN is 'unset' and update string formatting in reportBuildPushActionFailure() calls.

  • Behavior:
    • In joinTailnet(), skip tailnet join if BLACKSMITH_TAILSCALE_TOKEN is 'unset'.
  • Misc:
    • Change string formatting in reportBuildPushActionFailure() calls in startBlacksmithBuilder() and actionsToolkit.run().

This description was created by Ellipsis for 77a6a48. It will automatically update as commits are pushed.

@aayushshah15
Copy link
Author

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b0458c2 in 10 seconds

More details
  • Looked at 40 lines of code in 1 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main.ts:32
  • Draft comment:
    Checking for 'unset' is a good addition to ensure the token is not mistakenly used when not properly set.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change in the PR is to ignore the 'unset' value for the BLACKSMITH_TAILSCALE_TOKEN environment variable. This is a valid change to ensure that the token is not mistakenly used when it is not set properly.

Workflow ID: wflow_OvtlDLAiZO2xxHY9


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@aayushshah15 aayushshah15 reopened this Jan 1, 2025
@aayushshah15 aayushshah15 force-pushed the 01-01-src_ignore_unset_sentinel_value_for_tailscale_token branch from b0458c2 to 77a6a48 Compare January 1, 2025 07:03
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 77a6a48 in 11 seconds

More details
  • Looked at 40 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. src/main.ts:118
  • Draft comment:
    String formatting updated to use single quotes, consistent with the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR description mentions updating string formatting in reportBuildPushActionFailure() calls. The changes are consistent with this intent, replacing double quotes with single quotes for string literals.
2. src/main.ts:409
  • Draft comment:
    String formatting updated to use single quotes, consistent with the PR description.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The PR description mentions updating string formatting in reportBuildPushActionFailure() calls. The changes are consistent with this intent, replacing double quotes with single quotes for string literals.

Workflow ID: wflow_1vTPG4X5FXnXhvY0


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

ellipsis-dev bot commented Jan 1, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

@aayushshah15 aayushshah15 merged commit 4ed3ba5 into master Jan 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants