-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: ignore unset sentinel value for tailscale token #89
src: ignore unset sentinel value for tailscale token #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b0458c2 in 10 seconds
More details
- Looked at
40
lines of code in1
files - Skipped
2
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. src/main.ts:32
- Draft comment:
Checking for 'unset' is a good addition to ensure the token is not mistakenly used when not properly set. - Reason this comment was not posted:
Confidence changes required:0%
The change in the PR is to ignore the 'unset' value for the BLACKSMITH_TAILSCALE_TOKEN environment variable. This is a valid change to ensure that the token is not mistakenly used when it is not set properly.
Workflow ID: wflow_OvtlDLAiZO2xxHY9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
b0458c2
to
77a6a48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 77a6a48 in 11 seconds
More details
- Looked at
40
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. src/main.ts:118
- Draft comment:
String formatting updated to use single quotes, consistent with the PR description. - Reason this comment was not posted:
Confidence changes required:10%
The PR description mentions updating string formatting inreportBuildPushActionFailure()
calls. The changes are consistent with this intent, replacing double quotes with single quotes for string literals.
2. src/main.ts:409
- Draft comment:
String formatting updated to use single quotes, consistent with the PR description. - Reason this comment was not posted:
Confidence changes required:10%
The PR description mentions updating string formatting inreportBuildPushActionFailure()
calls. The changes are consistent with this intent, replacing double quotes with single quotes for string literals.
Workflow ID: wflow_1vTPG4X5FXnXhvY0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
|
Important
Skip tailnet join in
joinTailnet()
ifBLACKSMITH_TAILSCALE_TOKEN
is 'unset' and update string formatting inreportBuildPushActionFailure()
calls.joinTailnet()
, skip tailnet join ifBLACKSMITH_TAILSCALE_TOKEN
is 'unset'.reportBuildPushActionFailure()
calls instartBlacksmithBuilder()
andactionsToolkit.run()
.This description was created by for 77a6a48. It will automatically update as commits are pushed.