Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: stop spurious warnings on buildkit shutdown #78

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Dec 20, 2024

Important

Remove -f flag from pgrep buildkitd to prevent spurious warnings during shutdown in src/main.ts and src/setup_builder.ts.

  • Behavior:
    • Remove -f flag from pgrep buildkitd command in src/main.ts and src/setup_builder.ts to prevent spurious warnings during buildkitd shutdown.
    • Update logging in shutdownBuildkitd() in src/main.ts to include PID in debug messages.
    • Change log level from debug to info for successful buildkitd start message in startBuildkitd() in src/setup_builder.ts.

This description was created by Ellipsis for 4723a2a. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4723a2a in 11 seconds

More details
  • Looked at 41 lines of code in 2 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main.ts:318
  • Draft comment:
    Ensure that removing the -f flag from pgrep is consistent with the intended behavior. This change is also made in other parts of the codebase (e.g., lines 141, 493).
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR changes the pgrep command to remove the -f flag. This flag is used to match against the full command line, not just the process name. Removing it might cause issues if there are multiple processes with similar names, but the PR author likely intended this change to avoid false positives from matching against the full command line. However, this change should be consistent across the codebase.

Workflow ID: wflow_w3D8wi9ubIH1DNvd


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit 70572bc into master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant