Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main: ignore error when nothing is mounted #71

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Conversation

adityamaru
Copy link

@adityamaru adityamaru commented Dec 15, 2024

Important

Modify error handling in main.ts to log a debug message instead of a warning when no mounts are found during cleanup.

  • Error Handling:
    • In main.ts, modify error handling in the cleanup process to avoid logging a warning when mount | grep command fails due to no mounts found.
    • Specifically checks if error.code equals 1 and logs a debug message instead of a warning.

This description was created by Ellipsis for 53000f0. It will automatically update as commits are pushed.

@adityamaru adityamaru changed the title ignore error when nothing is mounted main: ignore error when nothing is mounted Dec 15, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 90230a7 in 26 seconds

More details
  • Looked at 19 lines of code in 1 files
  • Skipped 2 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_FpGcMRXq8uKP56Qa


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

src/main.ts Outdated Show resolved Hide resolved
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 53000f0 in 18 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/main.ts:401
  • Draft comment:
    The error object does not have a 'code' property; it should be 'error.code'.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_kqGORjOfPeaSbQ4B


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adityamaru adityamaru merged commit c7c5053 into master Dec 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant