Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Медведев Денис #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

DenyDeny
Copy link

@DenyDeny DenyDeny commented Oct 18, 2017

@honest-hrundel honest-hrundel changed the title Medvedev Denis Медведев Денис Oct 18, 2017
@honest-hrundel
Copy link

🍏 Пройден линтинг и базовые тесты

Copy link

@trixartem trixartem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍅
Не хватает элементов которые растянуты на несколько колонок

@font-face
{
font-family: annabelle;
src: local(anabelle), url(../fonts/annabelle.ttf);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь еще какой-нибудь формат шрифта

background: url('http://bit.ly/2fhRTzK');
}

input[name='size'][value='80']:checked ~ .content

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Почему бы просто классом не задать?

input[name='size'][value='80']:checked ~ .content h3,
input[name='size'][value='80']:checked ~ .content h2
{
font-size: 1.36rem;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше менять шрифт только на одном элементе и наследовать размеры от него

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants