Feature/#4 : 게임 Feign 추가, Socket 관련 코드 추가 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
oo-ni
commented
Feb 4, 2025
oo-ni
commented
- feign 관련 dto 추가
- WebSocketMessage에 MessageType 추가
- Reflection API 추가 -> 런타임에서 메서드 호출
- Reflection 사용 시 메서드 캐싱처리
- Socket 활용 부분 MessageType활용 switch-case로 수정
2 tasks
Ban-gilhyeon
reviewed
Feb 4, 2025
| case PLAYER_JOINED -> response = gameServiceClient.invitePlayer((PlayerReq) request.payload()).getBody(); | ||
| case PLAYER_REMOVED -> response = gameServiceClient.removePlayer((PlayerReq) request.payload()).getBody(); | ||
| case PLAYER_READY -> response = gameServiceClient.readyPlayer((PlayerReq) request.payload()).getBody(); | ||
| case CONTENT_SELECTED -> response = gameServiceClient.selectContent((ContentSelectReq) request.payload()).getBody(); |
There was a problem hiding this comment.
최신 case 문이네요 ..
까먹고 있었습니다 보기 좋네요 !
| public interface GameServiceClient { | ||
| @PostMapping("/player/invite") | ||
| @PostMapping("/api/game-service/room/player/invite") |
There was a problem hiding this comment.
@RequestMapping() 으로 정리하면 좋을 것 같네요 !
혹시 안쓰신 이유가 있으신가요?
There was a problem hiding this comment.
기존 API로 하던거 복붙해온거라.. 놓쳤네요 ㅎㅎ RequestMapping 좋아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.