helpers: more helpers #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should use these more broadly, but that would explode the linecount of the PR I want to make with largely unrelated changes...
This one can at least process the full noun always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9725793 does a light reorganization. I think splitting this up will be more sustainable as these sub-suites grow.
13e8fb6 provides nicer affordances for doing typechecking for
Nounobjects.I tried briefly, but in hindsight it's obvious we can't do any
isShape(myNoun, ['a', 'c', 'n'])(for?=([@ ^ *] my-noun)) style shenanigans. So I think theisMapstyle checkers are the best we can do. Maybe if you get a sufficient amount of those into the stdlib you're covering most of your bases, anyway.We should do a pass over the codebase to replace all
instanceofcode with these helpers, but that's out of scope for this PR.06e2549 provides
Noun-level set/map creation helpers. 2a9316f wraps those to provide "from non-Noundata" versions for thedejspart of the suite.c43bc86 and 89a0fc2 are attempts at simplifying some of the logic we wrote for the verifier stuff earlier this week.
There's probably stuff that I missed, may tack more on later as I write helpers for verifier work, but this should be a good start.