Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CI Action EOL #503

Merged
merged 4 commits into from
Jan 31, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use upload-artifact v4 with explicit names
vtnate committed Jan 31, 2025
commit 9cbc7a4f820b1a28ef44a3681382c473e0875dc3
5 changes: 2 additions & 3 deletions .github/workflows/nightly_ci_build.yml
Original file line number Diff line number Diff line change
@@ -56,11 +56,10 @@ jobs:
run: bundle exec rspec -e 'Run and work with a small ${{ matrix.simulation-type }} simulation'
- name: Upload artifacts
# Save results for examination - useful for debugging
uses: actions/upload-artifact@v3
# Using v4 would mean we have to change our path design, and/or the test dir names
uses: actions/upload-artifact@v4
# Only upload if a previous step fails
if: failure()
with:
name: rspec_results
name: rspec_results_${{ matrix.simulation-type }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the key change required by the upload-artifact version bump

path: artifact.zip
retention-days: 7 # save for 1 week then delete