Fix Protocol and Feature Headers in context.call #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
force-pushed
the
DX-1356-context-call-wf-and-feature-header
branch
2 times, most recently
from
1881006 to
723c24b
Compare
feature header was supposed to only be sent in context.call instead of all requests. this is fixed also, we don't forward the protocol header in the context.call request. this way, the request QStash makes doesn't have protocol header. so you can call another workflow endpoint.
CahidArda
force-pushed
the
DX-1356-context-call-wf-and-feature-header
branch
from
723c24b to
33508f1
Compare
fahreddinozcan
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature header was supposed to only be sent in context.call instead of all requests. this is fixed
also, we don't forward the protocol header in the context.call request. this way, the request QStash makes doesn't have protocol header. so you can call another workflow endpoint.
merge after #5