Merge pull request #5 from upbound/feature/deleteNodesOnDisconnect

feat(delete): add boolean deleteNodesOnDisconnect
upbound · Jan 31, 2024 · a59f2d4 · a59f2d4
2 parents 7afbd57 + 7246368
commit a59f2d4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/apis/fullaccess/composition.yaml b/apis/fullaccess/composition.yaml
@@ -482,13 +482,13 @@ spec:
             base:
               apiVersion: castai.aws.platform.upbound.io/v1alpha1
               kind: XReadOnly
-              spec:
-                parameters:
-                  deleteNodesOnDisconnect: false
             patches:
               - type: FromCompositeFieldPath
                 fromFieldPath: spec.parameters.id
                 toFieldPath: metadata.name
+              - type: FromCompositeFieldPath
+                fromFieldPath: spec.parameters.deleteNodesOnDisconnect
+                toFieldPath: spec.parameters.deleteNodesOnDisconnect
               - type: FromCompositeFieldPath
                 fromFieldPath: spec.parameters.region
                 toFieldPath: spec.parameters.region

diff --git a/apis/fullaccess/definition.yaml b/apis/fullaccess/definition.yaml
@@ -36,6 +36,10 @@ spec:
                     id:
                       type: string
                       description: ID of this Cluster that other objects will use to refer to it.
+                    deleteNodesOnDisconnect:
+                      type: boolean
+                      description: "Delete Nodes on Disconnect"
+                      default: false
                     clusterName:
                       type: string
                       description: "EKS ClusterName"
@@ -73,6 +77,7 @@ spec:
                     - securityGroups
                     - subnets
                     - vpc
+                    - deleteNodesOnDisconnect
               required:
                 - parameters
             status:

diff --git a/apis/readonly/definition.yaml b/apis/readonly/definition.yaml
@@ -48,6 +48,7 @@ spec:
                     deleteNodesOnDisconnect:
                       type: boolean
                       description: "Delete Nodes on Disconnect"
+                      default: false
                     assumeRoleArn:
                       type: string
                       description: "assumeRoleArn for this EKS Cluster Access for castai"
@@ -56,6 +57,7 @@ spec:
                     - accountId
                     - clusterName
                     - region
+                    - deleteNodesOnDisconnect
               required:
                 - parameters
             status: