Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ZoomContentControl as a stand alone control in Toolkit #1249

Merged
merged 30 commits into from
Oct 25, 2024
Merged

feat: ZoomContentControl as a stand alone control in Toolkit #1249

merged 30 commits into from
Oct 25, 2024

Conversation

vatsashah45
Copy link
Contributor

@vatsashah45 vatsashah45 commented Sep 18, 2024 •
edited
Loading

GitHub Issue (If applicable): closes #1109

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

ZoomContentControl doesn't exist in Toolkit

What is the new behavior?

Added ZoomContentControl to Tookit as a stand alone control
Added Samples, Tests and Docs for the same

PR Checklist

Please check if your PR fulfills the following requirements:

@vatsashah45 vatsashah45 self-assigned this Sep 18, 2024
@vatsashah45 vatsashah45 marked this pull request as draft September 18, 2024 21:12
@vatsashah45 vatsashah45 changed the title feat: ZoomContentControl is a stand alone control in Toolkit now feat: ZoomContentControl as a stand alone control in Toolkit Sep 19, 2024
@MartinZikmund
Copy link
Member

@vatsashah45 potentially for reference https://github.com/wieslawsoltes/PanAndZoom

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

Xiaoy312
Xiaoy312 reviewed Sep 23, 2024
View reviewed changes
doc/controls/ZoomContentControl.md Outdated Show resolved Hide resolved
...oolkit.Samples/Uno.Toolkit.Samples.Shared/Content/Controls/ZoomContentControlSamplePage.xaml Show resolved Hide resolved
...oolkit.Samples/Uno.Toolkit.Samples.Shared/Content/Controls/ZoomContentControlSamplePage.xaml Show resolved Hide resolved
doc/controls/ZoomContentControl.md Outdated Show resolved Hide resolved
doc/controls/ZoomContentControl.md Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ZoomContentControl/ZoomContentControl.xaml.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ZoomContentControl/ZoomContentControl.xaml.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ZoomContentControl/ZoomContentControl.xaml.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ZoomContentControl/ZoomContentControl.xaml.cs Outdated Show resolved Hide resolved
src/Uno.Toolkit.UI/Controls/ZoomContentControl/ZoomContentControl.xaml.cs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@vatsashah45 vatsashah45 marked this pull request as ready for review September 26, 2024 13:50
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/vs/zoom-content-control branch from b598c4c to ff4ee69 Compare October 17, 2024 22:47
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@MartinZikmund
Copy link
Member

@vatsashah45 Can you check the failing CI please?

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/vs/zoom-content-control branch from 185d83e to 11a2e0e Compare October 22, 2024 21:00
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/vs/zoom-content-control branch from 11a2e0e to d909908 Compare October 22, 2024 21:06
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/vs/zoom-content-control branch from bed83ed to 3fbb235 Compare October 23, 2024 01:02
@Xiaoy312 Xiaoy312 force-pushed the dev/vs/zoom-content-control branch from af2b051 to beb4d12 Compare October 23, 2024 01:38
@Xiaoy312
Copy link
Contributor

note: CI issue related to uwp build langversion and lack of syntax sugars... to fix

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

1 similar comment
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@Xiaoy312 Xiaoy312 force-pushed the dev/vs/zoom-content-control branch from 2fb035e to 4f68669 Compare October 23, 2024 20:42
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-field-01aa64f0f-1249.eastus2.azurestaticapps.net

@MartinZikmund MartinZikmund merged commit 279b9dd into main Oct 25, 2024
29 checks passed
@MartinZikmund MartinZikmund deleted the dev/vs/zoom-content-control branch October 25, 2024 12:27
@mergify mergify bot mentioned this pull request Oct 25, 2024
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@iurycarlos iurycarlos iurycarlos approved these changes

@Xiaoy312 Xiaoy312 Xiaoy312 approved these changes

@MartinZikmund MartinZikmund MartinZikmund approved these changes

@kazo0 kazo0 Awaiting requested review from kazo0

@agneszitte agneszitte Awaiting requested review from agneszitte

Assignees

@vatsashah45 vatsashah45

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ZoomContentControl
7 participants
@vatsashah45 @MartinZikmund @kazo0 @Xiaoy312 @iurycarlos @agneszitte @Youssef1313