Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix artifact handling for GitHub Actions v4 (backport #52) #55

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 13, 2024

PR Type

What kind of change does this PR introduce?

  • Build or CI related changes

What is the current behavior?

With latest change to update to download-artifact and upload-artifact to v4, only 1 artifact is now downloaded for the publication
Related previous PR: ci: Update download-artifact and upload-artifact to v4 #51

image

What is the new behavior?

  • Updated artifact upload steps to assign unique names (NuGet-Fluent, NuGet-Roboto, NuGet-OpenSans) to address changes introduced in actions/upload-artifact@v4.
  • Modified publish job to download artifacts by job-scoped names into separate directories (artifacts/fluent, artifacts/roboto, artifacts/opensans).
  • Adjusted signing and pushing steps to ensure consistent handling of artifacts across jobs and publishing.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

This is an automatic backport of pull request #52 done by [Mergify](https://mergify.com).

- Updated artifact upload steps to assign unique names (NuGet-Fluent, NuGet-Roboto, NuGet-OpenSans) to address changes introduced in actions/upload-artifact@v4.
- Modified publish job to download artifacts by job-scoped names into separate directories (artifacts/fluent, artifacts/roboto, artifacts/opensans).
- Adjusted signing and pushing steps to ensure consistent handling of artifacts across jobs and publishing.

(cherry picked from commit 28b88be)

# Conflicts:
#	.github/workflows/ci.yml
(cherry picked from commit de17c3a)
Copy link
Author

mergify bot commented Sep 13, 2024

Cherry-pick of 28b88be has failed:

On branch mergify/bp/release/stable/2.4/pr-52
Your branch is up to date with 'origin/release/stable/2.4'.

You are currently cherry-picking commit 28b88be.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@agneszitte
Copy link
Contributor

@Mergifyio refresh

@agneszitte agneszitte closed this Sep 13, 2024
@agneszitte agneszitte reopened this Sep 13, 2024
Copy link
Author

mergify bot commented Sep 13, 2024

refresh

✅ Pull request refreshed

@agneszitte agneszitte closed this Sep 13, 2024
@mergify mergify bot deleted the mergify/bp/release/stable/2.4/pr-52 branch September 13, 2024 14:35
@agneszitte agneszitte restored the mergify/bp/release/stable/2.4/pr-52 branch September 13, 2024 14:35
@agneszitte agneszitte reopened this Sep 13, 2024
@agneszitte agneszitte merged commit 8e27c70 into release/stable/2.4 Sep 13, 2024
2 checks passed
@agneszitte agneszitte deleted the mergify/bp/release/stable/2.4/pr-52 branch September 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant