Icon Font tester app #49
Conversation
There was a problem hiding this comment.
Nice. If would be good to build it as part of the CI.
There was a problem hiding this comment.
@jeromelaban, @MartinZikmund Even having a wasm static web app link would be helpful as well long term, to easily test the changes
| public async void OpenSelectionFolder() | ||
| { | ||
| var folder = await ApplicationData.Current.LocalFolder.CreateFolderAsync("UnoIconTest", CreationCollisionOption.OpenIfExists); | ||
| await Launcher.LaunchFolderAsync(folder); |
There was a problem hiding this comment.
@MartinZikmund I tested the application locally and I am getting some exceptions when trying to use the "Open selection folder" button.
For Desktop for example:
Exception thrown: 'System.NotImplementedException' in Uno.dll
An exception of type 'System.NotImplementedException' occurred in Uno.dll but was not handled in user code
The member IAsyncOperation<bool> Launcher.LaunchFolderAsync(IStorageFolder folder) is not implemented. For more information, visit https://aka.platform.uno/notimplemented#m=IAsyncOperation%3Cbool%3E%20Launcher.LaunchFolderAsync%28IStorageFolder%20folder%29
There was a problem hiding this comment.
Also "Open selection folder" button does not do anything for WASM and exceptions in the console.
For more info, I just checked out your branch, restored packages, and launched the app on the different platforms without changing anything else and getting exceptions.
If you can double-check all platforms on your side just in case, please.
| var dialog = new ContentDialog() | ||
| { | ||
| Title = "Error", | ||
| Content = "The selection.json file was not found in the Assets/Fonts/ folder. Add it, and click Refresh to try again.", | ||
| CloseButtonText = "Ok", | ||
| XamlRoot = XamlRoot | ||
| }; | ||
| await dialog.ShowAsync(); | ||
| return; |
There was a problem hiding this comment.
@MartinZikmund I have this exception for Android for example when launching the app locally:
System.InvalidOperationException: 'Trying to set position of the dialog before it is associated with a visual tree. This can happen if the dialog's XamlRoot was not set.'
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):