Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade to latest Capsize packages #319

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

michaeltaranto
Copy link
Contributor

@michaeltaranto michaeltaranto commented Feb 23, 2024

πŸ”— Linked issue

First step relating to this discussion.

Closes #317 and #318 (auto-generated PRs)

❓ Type of change

Open to discussing this one, selecting chore for now.

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Upgrading to the latest Capsize packages. This upgrade provides a few key benefits to the Fontaine 🀝 Capsize relationship:

  • Improved ESM compatibility
  • Improved types, with consumers encouraged to adopt a moduleResolution strategy that understands the package.json exports key, e.g. Bundler.
  • Updated xWidthAvg metric, now calculated from more extendable dataset (rather than hard coded English character frequencies) in preparation for supporting other unicode subsets, e.g. Thai.
    This is a move away from the original character frequencies collaborated on with the Google Aurora team, and seem to perform same or better, while also having the benefit of no longer being hard coded. As a result the snapshots of metrics and CSS have changed, but here is a visual example of the change to IBM Plex Mono (used in one of the snapshots):

No Capsize:
no capsize

With Capsize v1:
metrics v1

With Capsize v2:
metrics v2

Note also upgrading to Node 18 in CI due to missing fetch API. Hopefully thats ok given Node 16s move to EOL

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 54.01%. Comparing base (7fea517) to head (e8bc9e3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##              main     #319       +/-   ##
============================================
- Coverage   100.00%   54.01%   -45.99%     
============================================
  Files            2        4        +2     
  Lines          197      361      +164     
  Branches        31       33        +2     
============================================
- Hits           197      195        -2     
- Misses           0      166      +166     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@michaeltaranto
Copy link
Contributor Author

michaeltaranto commented Feb 23, 2024

It doesnt seem like the codecov bot has run since the action was updated, resulting in this PR showing a failed result πŸ€” .

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❀️ This is great, and really appreciate you taking the time.

@danielroe danielroe merged commit f8d28c2 into unjs:main Feb 23, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants