Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index generation for optimized hist fc with regression models #2623

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Dec 19, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Summary

  • fixes bug when performing optimized historical forecasts with RegressionModel and last_points_only=False, where the forecast index generation could result in out-of-bound dates.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.10%. Comparing base (71a1902) to head (a7cea7d).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2623      +/-   ##
==========================================
- Coverage   94.15%   94.10%   -0.06%     
==========================================
  Files         139      139              
  Lines       14992    14992              
==========================================
- Hits        14116    14108       -8     
- Misses        876      884       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 412d983 into master Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants