Miscellaneous JIT fixes #4930
Merged
Miscellaneous JIT fixes #4930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It pre-allocates a buffer of the maximal size, but wasn't truncating after the read completes. This results in a unison bytes with extra null bytes, which could even follow on to text with extra nulls.
- Reify/reflect booleans properly - Use exn:bug for errors during translation
Some of the modes weren't working. This switches the racket implementation of file opening instead of the r6rs one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are various fixes to jit stuff that I found by doing a search/replace of the transcripts to use
run.native. There are a couple I haven't fixed, because I'm not sure how yet (comparing thread pointers and lack of sized block buffering in racket).The following problems are fixed:
buggetSomeByteswas giving a result padded by null bytes in cases where the full requested amount wasn't availabledirectoryContentswas broken in a couple waysrun.nativesystemTimeZonewasn't implementedI didn't include any new tests, because these would all be caught by running transcripts with the jit runtime. We just don't at the moment.