Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to svelte 5 #3255

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat: migrate to svelte 5 #3255

wants to merge 4 commits into from

Conversation

o-az
Copy link
Member

@o-az o-az commented Nov 13, 2024

the first commit is the result of running npx sv@latest migrate svelte-5 without any manual changes.

2nd commit is result of this guide: https://next.shadcn-svelte.com/docs/migration/svelte-5

@o-az o-az requested review from cor and benluelo as code owners November 13, 2024 01:43
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 6:47am

@o-az
Copy link
Member Author

o-az commented Nov 15, 2024

update: this is shelved until tanstack query, tanstack table and shadcn-svelte are all svelte-5 ready and stable.

@o-az o-az marked this pull request as draft November 15, 2024 21:57
@cor cor added the S-shelved Status: Not actively being worked on, PR/issue still open for reference label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-shelved Status: Not actively being worked on, PR/issue still open for reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants