Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pagination button visibility when there's alert #3090

Merged
merged 2 commits into from
Oct 16, 2024
Merged

fix: pagination button visibility when there's alert #3090

merged 2 commits into from
Oct 16, 2024

Conversation

o-az
Copy link
Member

@o-az o-az commented Oct 11, 2024

fixes #3084

this solution is not perfect since it doesn't remove the applied style once the announcement is manually closed. The penalty is a little extra padding on bottom. But at least it makes nav buttons usable when there's an announcement

@o-az o-az requested review from cor and benluelo as code owners October 11, 2024 04:35
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 10:10am

Copy link

App 🤌

✨ Deployment complete! Take a peek over at https://2c017641.app-1b1.pages.dev
✨ Deployment alias URL: https://head.app-1b1.pages.dev


@cor cor merged commit e2cc40c into main Oct 16, 2024
131 checks passed
@cor cor deleted the fix-3084 branch October 16, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: can't view pagination buttons when there is an alert
3 participants