Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22901 Update Locale::init() to use StringPiece #3395

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

roubert
Copy link
Member

@roubert roubert commented Feb 13, 2025

Checklist

  • Required: Issue filed: ICU-22901
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@roubert
Copy link
Member Author

roubert commented Feb 13, 2025

This replaces the last instance in the locale code where a copy of some string is being made only because it needs to be NUL terminated for some internal API.

@roubert roubert marked this pull request as ready for review February 13, 2025 15:30
@roubert roubert requested a review from markusicu February 13, 2025 15:30
@roubert roubert merged commit 7da5e90 into unicode-org:main Feb 14, 2025
94 checks passed
@roubert roubert deleted the 22901-init branch February 14, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants