Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22781 Add test for portion format with parts per billion (Java) #3390

Merged
merged 1 commit into from
Feb 11, 2025
Merged

ICU-22781 Add test for portion format with parts per billion (Java) #3390

merged 1 commit into from
Feb 11, 2025

Conversation

younies
Copy link
Member

@younies younies commented Feb 11, 2025 •
edited
Loading

Description:

  • Expanded test cases for portion unit formatting
  • Added support for different locales (en-US, de-DE)
  • Improved test coverage for portion unit formatting
  • Added handling for known CLDR data limitations

Cpp code: #3389

Checklist

  • Required: Issue filed: ICU-22781
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@younies
ICU-22781 Enhance portion unit formatting tests in NumberFormatTest
32b7eee 
- Expanded test cases for portion unit formatting
- Added support for different locales (en-US, de-DE)
- Improved test coverage for portion unit formatting
- Added handling for known CLDR data limitations
This was referenced Feb 11, 2025
Merged
Merged
@younies younies requested review from sffc and richgillam February 11, 2025 18:50
richgillam
richgillam approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except maybe for my request for some added comments.

icu4j/main/common_tests/src/test/java/com/ibm/icu/dev/test/format/NumberFormatTest.java
new TestCase("portion-per-1e5", "en-US", 1, "UNKNOWN"),
new TestCase("portion-per-1e6", "en-US", 1, "UNKNOWN"),
new TestCase("portion-per-1e7", "en-US", 1, "UNKNOWN"),
new TestCase("portion-per-1e8", "en-US", 1, "UNKNOWN"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question/comment as in the C++ version of this change: It looks good, but if all of these UNKNOWN cases are things that'll be caught by the logKnownIssue() in the code below, you might want to put comments here indicating that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, all of them are being caught by logKnownIssue,

Okay, I will add a comment in a following PR.

@younies younies merged commit 030c79f into unicode-org:main Feb 11, 2025
15 checks passed
@younies younies deleted the java-test-format-portion2 branch February 12, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richgillam richgillam richgillam approved these changes

@sffc sffc Awaiting requested review from sffc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@younies @richgillam