-
-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22309 update to license v3, readme #2552
Conversation
need another readme fix (but license should be ok) |
I've reviewed the license language and it is all fine except the start date for the copyright notice - it should be 2016 as indicated in the spreadsheet I provided for the repos (and as noted by Markus). Also, the README language is not correct - it does not include everything that is in the spreadsheet |
Steven,
While the first year of the copyright notice should generally be the year
of first publication, that ICU is an exception - the earlier date is
included in the ICU license in the ICU license file. The Unicode copyright
notice should start at 2016, when Unicode took it over.
And there is no need for you to independently calculate the copyright
notice start date for each repo - I have done that for you already and it
is all in the spreadsheet
<https://docs.google.com/spreadsheets/d/1k2AOhTLEE1UtkJeawND-8ZdmDvPvbSH0lj5ai2B-QMo/edit#gid=1408776897>.
Just refer to that.
Anne
…On Mon, Aug 14, 2023 at 11:17 AM Steven R. Loomis ***@***.***> wrote:
need another readme fix (but license should be ok)
—
Reply to this email directly, view it on GitHub
<#2552 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2S6UI3QPULS2SXUD3F5LY3XVJTQRANCNFSM6AAAAAA3QA5QAA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
I am referring to that. The content in the LICENSE file is a mistake, I will fix it. |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
LICENSE, README.md, and CONTRIBUTING.md now have the required current features |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@annebright fixed title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes all look good, but need to remove the now redundant "License" section at the bottom of the Contributing page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes all look good, but need to remove the now redundant "License" section at the bottom of the Contributing page
- LICENSE is now the v3 license with the correct year and title - README.md now has the required features and drops Terms of Use - CONTRIBUTING.md now matches the updated language
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
i made it match the README, check now |
Checklist