Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22309 update to license v3, readme #2552

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 14, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22309
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)

@srl295 srl295 requested review from markusicu and annebright August 14, 2023 18:00
@srl295 srl295 self-assigned this Aug 14, 2023
@srl295 srl295 marked this pull request as draft August 14, 2023 18:16
@srl295
Copy link
Member Author

srl295 commented Aug 14, 2023

need another readme fix (but license should be ok)

@annebright annebright marked this pull request as ready for review August 14, 2023 20:41
@annebright
Copy link

I've reviewed the license language and it is all fine except the start date for the copyright notice - it should be 2016 as indicated in the spreadsheet I provided for the repos (and as noted by Markus). Also, the README language is not correct - it does not include everything that is in the spreadsheet

@annebright
Copy link

annebright commented Aug 14, 2023 via email

@srl295
Copy link
Member Author

srl295 commented Aug 14, 2023

Steven, While the first year of the copyright notice should generally be the year of first publication, that ICU is an exception - the earlier date is included in the ICU license in the ICU license file. The Unicode copyright notice should start at 2016, when Unicode took it over. And there is no need for you to independently calculate the copyright notice start date for each repo - I have done that for you already and it is all in the spreadsheet https://docs.google.com/spreadsheets/d/1k2AOhTLEE1UtkJeawND-8ZdmDvPvbSH0lj5ai2B-QMo/edit#gid=1408776897. Just refer to that. Anne

I am referring to that. The content in the LICENSE file is a mistake, I will fix it.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • CONTRIBUTING.md is now changed in the branch
  • LICENSE is different
  • README.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 requested a review from yumaoka August 15, 2023 22:59
@srl295
Copy link
Member Author

srl295 commented Aug 15, 2023

LICENSE, README.md, and CONTRIBUTING.md now have the required current features

@srl295
Copy link
Member Author

srl295 commented Aug 15, 2023

unicode-org/.github#6

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • README.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • README.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

annebright
annebright previously approved these changes Aug 16, 2023
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • LICENSE is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Aug 18, 2023

@annebright fixed title

markusicu
markusicu previously approved these changes Aug 18, 2023
LICENSE Show resolved Hide resolved
Copy link

@annebright annebright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good, but need to remove the now redundant "License" section at the bottom of the Contributing page

annebright
annebright previously approved these changes Aug 18, 2023
Copy link

@annebright annebright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good, but need to remove the now redundant "License" section at the bottom of the Contributing page

- LICENSE is now the v3 license with the correct year and title
- README.md now has the required features and drops Terms of Use
- CONTRIBUTING.md now matches the updated language
@srl295 srl295 dismissed stale reviews from annebright and markusicu via 6c22d81 August 18, 2023 18:26
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • CONTRIBUTING.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Aug 18, 2023

Changes all look good, but need to remove the now redundant "License" section at the bottom of the Contributing page

i made it match the README, check now

@srl295 srl295 merged commit 248b1c2 into unicode-org:main Aug 21, 2023
@srl295 srl295 deleted the licensev3 branch August 21, 2023 16:48
@markusicu markusicu mentioned this pull request Oct 4, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants