Skip to content

Commit

Permalink
ICU-22991 Revert back gregoimp interface change
Browse files Browse the repository at this point in the history
  • Loading branch information
FrankYFTang committed Jan 22, 2025
1 parent f7822bd commit aa3c032
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions icu4c/source/i18n/gregoimp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ double ClockMath::floorDivide(double numerator, int32_t denominator,
}

double ClockMath::floorDivide(double dividend, double divisor,
int32_t* remainder) {
double* remainder) {
// Only designed to work for positive divisors
U_ASSERT(divisor > 0);
double quotient = floorDivide(dividend, divisor);
int32_t r = dividend - (quotient * divisor);
double r = dividend - (quotient * divisor);
// N.B. For certain large dividends, on certain platforms, there
// is a bug such that the quotient is off by one. If you doubt
// this to be true, set a breakpoint below and run cintltst.
Expand Down
2 changes: 1 addition & 1 deletion icu4c/source/i18n/gregoimp.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class ClockMath {
* Calling with a divisor <= 0 is disallowed.
*/
static double floorDivide(double dividend, double divisor,
int32_t* remainder);
double* remainder);
};

// Useful millisecond constants
Expand Down

0 comments on commit aa3c032

Please sign in to comment.