CLDR-16022 Add test to detect new aliases for BCP47 keys or non-tz values #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
commented
Feb 10, 2025
| // Currently <convertUnits> - and consequently allowedBcp47Units - has a temperature unit | ||
| // rankine which is not supported for mu, and hence not in typesFound. | ||
| // Filed CLDR-18300 about this but meanwhile typesFound just needs to be a subset of | ||
| // allowedBcp47Units. |
There was a problem hiding this comment.
see CLDR-18300 "Support for measure unit Rankine?"
pedberg-icu
commented
Feb 10, 2025
| @@ -185,6 +185,7 @@ public TestAll() { | |||
| "org.unicode.cldr.unittest.TestAnnotations", | |||
| "org.unicode.cldr.unittest.TestAttributeValues", | |||
| "org.unicode.cldr.unittest.TestBasic", | |||
| "org.unicode.cldr.unittest.TestBCP47", | |||
There was a problem hiding this comment.
see CLDR-18301 "TestAll() in unittest/TestAll.java does not include all of the tests in unittest; should it?"
There was a problem hiding this comment.
Also https://unicode-org.atlassian.net/browse/CLDR-17708 — mostly the same?
There was a problem hiding this comment.
Yes, thanks, I resolved CLDR-18301 as a duplicate of CLDR-17708 and copied the linked issues over.
macchiati
approved these changes
Feb 11, 2025
pedberg-icu
deleted the
CLDR-16022-test-no-new-aliases-for-BCP47-except-tz
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-16022
Add a test that detects any new aliases for BCP47 keys, or for BCP47 types other than tz types (for tz types the alias contains the tzdata name so any new zones will require an alias); these should not be added. This test depends on having the cldr-archive available (since it compares BCP47 aliases in the current version to those in the previous version), and is skipped if the flag is set indicating that the archive is not available.
This also adds the unit test TestBCP47 to TestAll(); there are probably more unit tests that should be added to TestAll(), filed CLDR-18301 about that.
ALLOW_MANY_COMMITS=true