Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18268 Add HH timeFormat to en_GS #4320

Merged
merged 1 commit into from
Jan 29, 2025
Merged

CLDR-18268 Add HH timeFormat to en_GS #4320

merged 1 commit into from
Jan 29, 2025

Conversation

AEApple
Copy link
Contributor

@AEApple AEApple commented Jan 29, 2025

CLDR-18268

Add HH timeFormat to en_GS

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@AEApple AEApple requested a review from DraganBesevic January 29, 2025 00:01
@AEApple AEApple self-assigned this Jan 29, 2025
@AEApple AEApple requested a review from pedberg-icu January 29, 2025 00:01
@AEApple AEApple marked this pull request as ready for review January 29, 2025 00:01
@AEApple
Copy link
Contributor Author

AEApple commented Jan 29, 2025

Note: I don't think we'll probably need this, but I created it in case we do, and will abandon if we don't. It was hard to tell what en_GB was doing so I copied the formats from en_IE just in case.

Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en_GB has explicit gregorian timeformats using H, and what you have for en_GS matches the en_GB formats; en_GB is not inheriting from en_001, which inherits h-cycle timeFormats from en. So what you have here is necessary.

@AEApple
Copy link
Contributor Author

AEApple commented Jan 29, 2025

en_GB has explicit gregorian timeformats using H, and what you have for en_GS matches the en_GB formats; en_GB is not inheriting from en_001, which inherits h-cycle timeFormats from en. So what you have here is necessary.

Thanks! I must have mis-read the en_GB file when I originally checked it. I'll merge this in. Longer term I want to check what the most common hour cycle is and update it.

@AEApple AEApple merged commit 3453b29 into main Jan 29, 2025
14 checks passed
@AEApple AEApple deleted the AEApple-CLDR-18268 branch January 29, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants