Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various UI and history fixes #2926

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

Ahrotahn
Copy link
Contributor

This PR contains a series of commits that address some existing issues:

This is also the first time the new changes in the close confirmation patch are being refreshed by quilt, no functional changes have been made.

@Ahrotahn Ahrotahn requested a review from a team as a code owner June 23, 2024 18:51
</if>
<div class="flex cr-padded-text">
-<if expr="not chromeos_ash">
+<if expr="False">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this fixes the extra error message! 🎉

image

However, there's still an error icon, which I believe is at line 55 of chrome/browser/resources/settings/about_page/about_page.html you patched (the other <if expr="not chromeos_ash">). Maybe we should also make that <if expr="False">?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, I'll update the PR with that in a bit!

@PF4Public
Copy link
Contributor

@Ahrotahn Have you checked that mailto: links didn't regress with your changes?

@Ahrotahn
Copy link
Contributor Author

Yup! Copying mailto links doesn't include the mailto prefix when I tested.

@networkException networkException merged commit d12438d into ungoogled-software:master Jun 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants