Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JmeterNamesTemplater v1.1 and UtilityJmeterFunctions v1.1.3 #665

Merged
merged 7 commits into from
Aug 25, 2024

Conversation

DanilGolikov
Copy link
Contributor

Created JmeterNamesTemplater that allows you to rename items according to the config file

site/dat/repo/various.json Outdated Show resolved Hide resolved
site/dat/repo/various.json Show resolved Hide resolved
@DanilGolikov
Copy link
Contributor Author

Hi! I corrected the namespace, I didn't pay attention to the fact that it looks stupid xD before.
I also added another plugin (CustomJmeterFunctions), with your recommendations

@DanilGolikov DanilGolikov requested a review from undera August 22, 2024 04:55
DanilGolikov

This comment was marked as spam.

site/dat/repo/various.json Outdated Show resolved Hide resolved
@undera
Copy link
Owner

undera commented Aug 25, 2024

Please make the title of PR to reflect what is inside. Look at other PRs to get the idea

Copy link
Owner

@undera undera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments

@DanilGolikov DanilGolikov changed the title Update various.json JmeterNamesTemplater v1.1 and AuxiliaryJmeterFunctions v1.1.3 Aug 25, 2024
@DanilGolikov DanilGolikov changed the title JmeterNamesTemplater v1.1 and AuxiliaryJmeterFunctions v1.1.3 JmeterNamesTemplater v1.1 and UtilityJmeterFunctions v1.1.3 Aug 25, 2024
@DanilGolikov DanilGolikov requested a review from undera August 25, 2024 11:50
@undera
Copy link
Owner

undera commented Aug 25, 2024

Looks like your JSON violate descriptor schema: https://github.com/undera/jmeter-plugins/actions/runs/10546658418/job/29218873882?pr=665

@undera
Copy link
Owner

undera commented Aug 25, 2024

Looks good now

@undera undera merged commit 59c7bb7 into undera:master Aug 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants