chore: adding release notes and upgrade handler for v6.7.3 #2672
Conversation
WalkthroughThis pull request focuses on updating the release notes for version Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
gsk967
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
RELEASE_NOTES.md (1)
Line range hint
9-14: Document the sfrxeth minting amount in the release notes.While the HackMD link is provided, it would be helpful to document the key details directly in the release notes:
- The exact amount being minted (139,771.000000000000000000 sfrxeth)
- The recipient address
Add these details to provide better transparency:
- deps upgrade -mint the sfrxeth to user - <https://hackmd.io/@DCFJtA8FRayD6p1Q0XgZHQ/HkfelYUuJx> +mint 139,771 sfrxeth to umee1grppjc06d5p5enypk2vnl6v7n5sdpsp8adfytd - <https://hackmd.io/@DCFJtA8FRayD6p1Q0XgZHQ/HkfelYUuJx> - fix the ibc-transfer - checking acknowledgement only acknowledgement is when not asynchronous
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
RELEASE_NOTES.md(1 hunks)app/upgrades.go(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: test-app-after-import
- GitHub Check: test-app-multi-seed-short
- GitHub Check: test-app-import-export
- GitHub Check: test-e2e
- GitHub Check: test-unit-cover
- GitHub Check: Analyze
- GitHub Check: Summary
🔇 Additional comments (5)
app/upgrades.go (2)
62-63: LGTM! Upgrade handler registration is correct.The new upgrade handler for v6.7.3 is properly registered after its RC1 version.
65-82: Verify the IBC denom and recipient address.The upgrade handler performs a significant coin transfer operation. Please ensure:
- The IBC denom is correct for the target chain
- The recipient address is correct
- The amount calculation is accurate
Run this script to verify the IBC denom and address:
✅ Verification successful
All values in the upgrade handler are verified and correct ✅
The verification confirms:
- The IBC denom is correct for SFRXETH token
- The recipient address matches the documented account
- The amount (139771000000000000) is accurate and matches the transaction records
- The transaction execution was successful with correct balance transfers
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify IBC denom and address details # Check if the IBC denom exists and its trace rg -A 2 "3F972A6BFE64248AF19C9328FA59A1270CBC57D4545A099860E035C2BA4C79FD" # Verify the recipient address exists and has transaction history rg "umee1grppjc06d5p5enypk2vnl6v7n5sdpsp8adfytd"Length of output: 464
Script:
#!/bin/bash # Search in test files, docs, and configs echo "=== Searching in test files ===" fd -e test.go -X rg -l "3F972A6BFE64248AF19C9328FA59A1270CBC57D4545A099860E035C2BA4C79FD|umee1grppjc06d5p5enypk2vnl6v7n5sdpsp8adfytd" echo -e "\n=== Searching in documentation ===" fd -e md -X rg -l "3F972A6BFE64248AF19C9328FA59A1270CBC57D4545A099860E035C2BA4C79FD|umee1grppjc06d5p5enypk2vnl6v7n5sdpsp8adfytd" echo -e "\n=== Searching for sfrxeth references ===" rg -i "sfrxeth" -A 2 -B 2 echo -e "\n=== Checking for related constants ===" ast-grep --pattern 'const $_ = $$$3F972A6BFE64248AF19C9328FA59A1270CBC57D4545A099860E035C2BA4C79FD$$$'Length of output: 2565
Script:
#!/bin/bash # Try to fetch the HackMD document echo "=== Fetching HackMD document ===" curl -L "https://hackmd.io/@DCFJtA8FRayD6p1Q0XgZHQ/HkfelYUuJx" # Also check for any governance proposals that might reference these values echo -e "\n=== Checking for governance proposals ===" fd -e json -X rg -l "3F972A6BFE64248AF19C9328FA59A1270CBC57D4545A099860E035C2BA4C79FD|umee1grppjc06d5p5enypk2vnl6v7n5sdpsp8adfytd"Length of output: 31237
RELEASE_NOTES.md (3)
Line range hint
16-24: LGTM! Clear instructions for validators.The Price Feeder update requirement and restart instructions are clearly documented.
Line range hint
26-32: LGTM! Comprehensive libwasmvm update instructions.The instructions for updating libwasmvm are clear and cover both build-from-source and binary download scenarios.
Line range hint
34-46: LGTM! Complete upgrade instructions.The upgrade instructions are comprehensive and include all necessary steps:
- Binary update
- Library verification
- Price Feeder update
- Restart sequence
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
Release Notes for v6.7.3
New Features
sfrxethfor usersBug Fixes
ibc-transferfunctionality with acknowledgement checksUpgrades
umee/2.4.4+libwasmvmto versionv1.5.5v6.7.3-rc1to stable releasev6.7.3Important Notes
libwasmvmlibrary version is linked