Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the goreleaser #2581

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: fix the goreleaser #2581

merged 1 commit into from
Aug 2, 2024

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Aug 2, 2024

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • Chores
    • Updated the build process to ensure a clean state by modifying build and release arguments.
    • Adjusted build configuration to focus solely on Linux (amd64 architecture) by commenting out macOS and arm64 options.
    • Disabled changelog generation to streamline release artifacts.

@gsk967 gsk967 requested a review from a team as a code owner August 2, 2024 15:29
Copy link
Contributor

coderabbitai bot commented Aug 2, 2024

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The updates to the GitHub Actions and GoReleaser configuration files streamline the build and release processes by emphasizing a clean build environment. Modifications include changing command arguments to ensure all prior artifacts are removed and focusing builds solely on the amd64 architecture for Linux, while disabling changelog generation. These changes aim to enhance reliability and reduce potential issues from previous builds.

Changes

Files Change Summary
.github/workflows/release-umee.yml
.goreleaser.yml
Updated build and release commands to ensure clean states, removing old artifacts. Disabled builds for darwin and arm64, and changed changelog generation behavior.

Poem

In a meadow bright and wide,
A rabbit hops with joyful pride.
Clean builds now, no mess to find,
Release notes clear, all well-defined.
With every change, we leap and cheer,
For smoother paths throughout the year! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gsk967 gsk967 added the skip-e2e-test Skip the e2e tests label Aug 2, 2024
@gsk967 gsk967 requested review from adamewozniak and removed request for a team August 2, 2024 15:29
@gsk967 gsk967 enabled auto-merge August 2, 2024 15:31
@gsk967 gsk967 requested review from hoffmabc and removed request for adamewozniak August 2, 2024 15:31
Copy link

@hoffmabc hoffmabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsk967 gsk967 added this pull request to the merge queue Aug 2, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d322a95 and d588543.

Files selected for processing (2)
  • .github/workflows/release-umee.yml (1 hunks)
  • .goreleaser.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .goreleaser.yml
Additional comments not posted (2)
.github/workflows/release-umee.yml (2)

50-50: LGTM! Verify the inclusion of release notes.

The updated arguments ensure a clean release and include release notes. This change emphasizes a clean release environment and might be necessary to avoid issues from prior builds.

Ensure that the release notes (--release-notes ./RELEASE_NOTES.md) are correctly included and up-to-date.

Verification successful

LGTM! The release notes are included and up-to-date.

The RELEASE_NOTES.md file was last modified on August 2, 2024, which confirms it is current and relevant for the release process.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the inclusion of release notes.

# Test: Search for the `RELEASE_NOTES.md` file in the codebase. Expect: The file exists and is up-to-date.
fd RELEASE_NOTES.md

Length of output: 38


Script:

#!/bin/bash
# Description: Check the last few lines of the RELEASE_NOTES.md file to ensure it is up-to-date.

# Display the last 10 lines of the RELEASE_NOTES.md file.
tail -n 10 RELEASE_NOTES.md

Length of output: 521


Script:

#!/bin/bash
# Description: Check the last modification date of the RELEASE_NOTES.md file to ensure it is up-to-date.

# Display the last modification date of the RELEASE_NOTES.md file.
stat -c %y RELEASE_NOTES.md

Length of output: 101


Script:

#!/bin/bash
# Description: Check the last modification date of the RELEASE_NOTES.md file using git log.

# Display the last commit date that modified the RELEASE_NOTES.md file.
git log -1 --format=%cd -- RELEASE_NOTES.md

Length of output: 75


42-42: LGTM! Verify the reasoning behind skipping initial sanity checks.

The updated arguments ensure a clean build and skip initial sanity checks. This change emphasizes a clean build environment and might be necessary to avoid issues from prior builds.

Ensure that skipping the initial sanity checks (--skip=before,validate) is intentional and does not introduce any risks.

Merged via the queue into main with commit 2acc4a7 Aug 2, 2024
21 of 35 checks passed
@gsk967 gsk967 deleted the sai/fix_goreleaser branch August 2, 2024 15:34
gsk967 added a commit that referenced this pull request Aug 6, 2024
* update release notes (#2575)

* update the params for mainnet (#2580)

* fix: fix the goreleaser (#2581)
@coderabbitai coderabbitai bot mentioned this pull request Dec 6, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants