-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the goreleaser #2581
fix: fix the goreleaser #2581
Conversation
Important Review skippedAuto reviews are limited to specific labels. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe updates to the GitHub Actions and GoReleaser configuration files streamline the build and release processes by emphasizing a clean build environment. Modifications include changing command arguments to ensure all prior artifacts are removed and focusing builds solely on the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/release-umee.yml (1 hunks)
- .goreleaser.yml (2 hunks)
Files skipped from review due to trivial changes (1)
- .goreleaser.yml
Additional comments not posted (2)
.github/workflows/release-umee.yml (2)
50-50
: LGTM! Verify the inclusion of release notes.The updated arguments ensure a clean release and include release notes. This change emphasizes a clean release environment and might be necessary to avoid issues from prior builds.
Ensure that the release notes (
--release-notes ./RELEASE_NOTES.md
) are correctly included and up-to-date.Verification successful
LGTM! The release notes are included and up-to-date.
The
RELEASE_NOTES.md
file was last modified on August 2, 2024, which confirms it is current and relevant for the release process.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the inclusion of release notes. # Test: Search for the `RELEASE_NOTES.md` file in the codebase. Expect: The file exists and is up-to-date. fd RELEASE_NOTES.mdLength of output: 38
Script:
#!/bin/bash # Description: Check the last few lines of the RELEASE_NOTES.md file to ensure it is up-to-date. # Display the last 10 lines of the RELEASE_NOTES.md file. tail -n 10 RELEASE_NOTES.mdLength of output: 521
Script:
#!/bin/bash # Description: Check the last modification date of the RELEASE_NOTES.md file to ensure it is up-to-date. # Display the last modification date of the RELEASE_NOTES.md file. stat -c %y RELEASE_NOTES.mdLength of output: 101
Script:
#!/bin/bash # Description: Check the last modification date of the RELEASE_NOTES.md file using git log. # Display the last commit date that modified the RELEASE_NOTES.md file. git log -1 --format=%cd -- RELEASE_NOTES.mdLength of output: 75
42-42
: LGTM! Verify the reasoning behind skipping initial sanity checks.The updated arguments ensure a clean build and skip initial sanity checks. This change emphasizes a clean build environment and might be necessary to avoid issues from prior builds.
Ensure that skipping the initial sanity checks (
--skip=before,validate
) is intentional and does not introduce any risks.
Description
closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit