Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix the build issue #2353

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: fix the build issue #2353

merged 1 commit into from
Dec 11, 2023

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Dec 10, 2023

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 requested a review from a team as a code owner December 10, 2023 12:54
Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Merging #2353 (52dc416) into main (7f05ad4) will decrease coverage by 5.34%.
Report is 314 commits behind head on main.
The diff coverage is 66.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   75.38%   70.05%   -5.34%     
==========================================
  Files         100      171      +71     
  Lines        8025    12665    +4640     
==========================================
+ Hits         6050     8873    +2823     
- Misses       1589     3187    +1598     
- Partials      386      605     +219     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
app/upgradev3/migrations.go 84.21% <ø> (+5.94%) ⬆️
util/coin/utoken.go 100.00% <100.00%> (ø)
util/ibc/ibc.go 58.82% <ø> (ø)
util/sdkutil/events.go 0.00% <ø> (ø)
util/store/store.go 52.06% <ø> (+10.65%) ⬆️
util/store/unmarshal.go 42.85% <ø> (ø)
... and 40 more

... and 110 files with indirect coverage changes

@gsk967 gsk967 enabled auto-merge December 11, 2023 09:45
@gsk967 gsk967 added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 6c1ad6c Dec 11, 2023
22 of 24 checks passed
@gsk967 gsk967 deleted the sai/fix_build branch December 11, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants