Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify and cleanup upgrades.go #2324

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

robert-zaremba
Copy link
Member

Description

Upgrades.go file got lot of legacy code which is safe to remove. The latest binary can't use it because the existing keepers are not backward compatible. So we are good to remove, and only keep 1-2 examples.

@robert-zaremba robert-zaremba requested review from a team as code owners November 14, 2023 15:06
@robert-zaremba robert-zaremba added the skip-e2e-test Skip the e2e tests label Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #2324 (3b7e2fd) into main (7f05ad4) will decrease coverage by 4.77%.
Report is 291 commits behind head on main.
The diff coverage is 66.58%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
- Coverage   75.38%   70.62%   -4.77%     
==========================================
  Files         100      170      +70     
  Lines        8025    12872    +4847     
==========================================
+ Hits         6050     9091    +3041     
- Misses       1589     3176    +1587     
- Partials      386      605     +219     
Files Coverage Δ
ante/ante.go 66.66% <100.00%> (+18.45%) ⬆️
ante/fee.go 80.00% <100.00%> (+1.64%) ⬆️
ante/spam_prevention.go 75.92% <ø> (ø)
app/inflation/inflation.go 100.00% <100.00%> (ø)
app/upgradev3/migrations.go 84.21% <ø> (+5.94%) ⬆️
util/coin/utoken.go 100.00% <100.00%> (ø)
util/ibc/ibc.go 58.82% <ø> (ø)
util/sdkutil/events.go 0.00% <ø> (ø)
util/store/unmarshal.go 42.85% <ø> (ø)
x/incentive/client/tests/suite.go 100.00% <ø> (ø)
... and 40 more

... and 102 files with indirect coverage changes

Copy link
Collaborator

@gsk967 gsk967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , small suggestion may be we can keep current running upgrade handler

@robert-zaremba robert-zaremba added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2023
@robert-zaremba robert-zaremba added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit b7f9124 Nov 14, 2023
@robert-zaremba robert-zaremba deleted the robert/upgrades-simplification branch November 14, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-e2e-test Skip the e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants