-
Notifications
You must be signed in to change notification settings - Fork 161
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(uibc): refactore to make the uibc stack more modular (#2343)
* refactore x/uibc * fix build * rename * move ibc quota logic to quota keeper * update middleware implementation * fixes * lint * review * lint * fix test
- Loading branch information
1 parent
fba6dec
commit 809fa08
Showing
26 changed files
with
269 additions
and
254 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| package quota | ||
|
|
||
| import ( | ||
| "cosmossdk.io/errors" | ||
| sdkmath "cosmossdk.io/math" | ||
| sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" | ||
| ics20types "github.com/cosmos/ibc-go/v7/modules/apps/transfer/types" | ||
| channeltypes "github.com/cosmos/ibc-go/v7/modules/core/04-channel/types" | ||
| "github.com/cosmos/ibc-go/v7/modules/core/exported" | ||
|
|
||
| ibcutil "github.com/umee-network/umee/v6/util/ibc" | ||
| "github.com/umee-network/umee/v6/util/sdkutil" | ||
| "github.com/umee-network/umee/v6/x/uibc" | ||
| ) | ||
|
|
||
| func (k Keeper) IBCOnSendPacket(packet []byte) error { | ||
| params := k.GetParams() | ||
|
|
||
| if !params.IbcStatus.IBCTransferEnabled() { | ||
| return ics20types.ErrSendDisabled | ||
| } | ||
|
|
||
| funds, denom, err := ibcutil.GetFundsFromPacket(packet) | ||
| if err != nil { | ||
| return errors.Wrap(err, "bad packet in rate limit's SendPacket") | ||
| } | ||
|
|
||
| if params.IbcStatus.OutflowQuotaEnabled() { | ||
| if err := k.CheckAndUpdateQuota(denom, funds); err != nil { | ||
| return errors.Wrap(err, "sendPacket over the IBC Quota") | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (k Keeper) IBCOnRecvPacket(packet channeltypes.Packet) exported.Acknowledgement { | ||
| params := k.GetParams() | ||
| if !params.IbcStatus.IBCTransferEnabled() { | ||
| return channeltypes.NewErrorAcknowledgement(ics20types.ErrReceiveDisabled) | ||
| } | ||
|
|
||
| if params.IbcStatus.OutflowQuotaEnabled() { | ||
| var data ics20types.FungibleTokenPacketData | ||
| if err := ics20types.ModuleCdc.UnmarshalJSON(packet.GetData(), &data); err != nil { | ||
| ackErr := sdkerrors.ErrInvalidType.Wrap("cannot unmarshal ICS-20 transfer packet data") | ||
| return channeltypes.NewErrorAcknowledgement(ackErr) | ||
| } | ||
|
|
||
| isSourceChain := ics20types.SenderChainIsSource(packet.GetSourcePort(), packet.GetSourceChannel(), data.Denom) | ||
| ackErr := k.RecordIBCInflow(packet, data.Denom, data.Amount, isSourceChain) | ||
| if ackErr != nil { | ||
| return ackErr | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // IBCRevertQuotaUpdate must be called on packet acknnowledgemenet error or timeout to revert | ||
| // necessary changes. | ||
| func (k Keeper) IBCRevertQuotaUpdate(amount, denom string) { | ||
| params := k.GetParams() | ||
| if !params.IbcStatus.OutflowQuotaEnabled() { | ||
| return | ||
| } | ||
| if err := k.revertQuotaUpdateStr(amount, denom); err != nil { | ||
| k.ctx.Logger().Error("revert quota update error", "err", err) | ||
| sdkutil.Emit(k.ctx, &uibc.EventBadRevert{ | ||
| FailureType: "ibc-ack", | ||
| Packet: amount + denom, | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func (k Keeper) revertQuotaUpdateStr(amount, denom string) error { | ||
| amountInt, ok := sdkmath.NewIntFromString(amount) | ||
| if !ok { | ||
| return sdkerrors.ErrInvalidRequest.Wrapf("invalid transfer amount %s", amount) | ||
| } | ||
| return k.UndoUpdateQuota(denom, amountInt) | ||
| } |
Oops, something went wrong.