-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration of Health Monitoring System (HMS) as a module #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice job 🚀 🌟
I added few minor comments, and also double check the documentation if you have to add any new topic/module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @amoramar ! 🎊 I left you a few comments, but nothing major.
Let me know what you think!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 👍 🎊 🥇
Basic Info
Description of contribution in a few bullet points
psdk_wrapper
librarypsdk_interfaces
,HmsInfoMsg
andHmsInfoTable
Motivation and Context
Unable to take off
, which is a very important piece of information for the end user.How Has This Been Tested?
Description of documentation updates required from your changes
psdk_ros2/hms_info_table
encapsulates all the information received from the PSDKsamples
folder for thehms
moduleCMakeLists.txt
in this repository will install the contents of the aforementioned folder locally, thus it will keep track of upstream changesFuture work that may be required in bullet points
Screenshots (if appropriate):