Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get/set focus ring services #151

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

michele-colombo
Copy link


Basic Info

Ticket(s) this addresses none
Primary OS tested on Ubuntu
Drone platform tested on M300 with H20 payload

Note: This is a continuation of this pull request: #148, with requested modifications implemented. I copy here the text from the original PR for consistency.

Description of contribution in a few bullet points

Added three services:

  • get focus range value: to get the range of values accepted for the focus in manual focus mode
  • set focus ring value: to set the value of the focus ring
  • get focus ring value: to get the current value of the focus ring

Motivation and Context

We needed this infos to manually regulate focus for specific applications.

How Has This Been Tested?

We tested these services by calling them both from terminal and from within nodes with the H20 payload.

Description of documentation updates required from your changes

Add new services in the camera setting section of the doc.


@michele-colombo michele-colombo requested a review from a team as a code owner November 21, 2024 14:33
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @michele-colombo ! Thanks for the contribution 🎊

@biancabnd biancabnd merged commit 1625684 into umdlife:main Nov 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants