Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C4GHStorage on Url and S3 storage backends #268

Merged
merged 7 commits into from
Sep 30, 2024
Merged

feat: add C4GHStorage on Url and S3 storage backends #268

merged 7 commits into from
Sep 30, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Sep 25, 2024 •
edited
Loading

Changes

  • Enables the C4GHStorage backend to use S3Storage and UrlStorage in configuration and in htsget-storage.
  • Bump github action versions.

Addresses the first point in #262 (comment).

@mmalenic mmalenic self-assigned this Sep 25, 2024
@mmalenic mmalenic added the enhancement New feature or request label Sep 25, 2024
@mmalenic mmalenic requested a review from brainstorm September 25, 2024 07:35
brainstorm
brainstorm requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marko! I'd change a couple of names if that's ok with you? That can help users (like Jimmy?) to understand the config flags better, IMHO. Let me know what you think!

htsget-config/src/storage/s3.rs Outdated Show resolved Hide resolved
htsget-config/README.md Outdated Show resolved Hide resolved
htsget-http/README.md Outdated Show resolved Hide resolved
brainstorm
brainstorm approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mmalenic
Copy link
Member Author

mmalenic commented Sep 30, 2024 •
edited
Loading

Updates

  • Renamed type to backend.
  • Clarify experimental feature flag comments.
  • Removed ObjectType in favour of flattened keys inside the storage structs /cc @brainstorm.
  • Make the overflow handling logic more robust when converting encrypted/unencrypted byte ranges.
  • Bump noodles and tower dependencies. This should close https://github.com/umccr/htsget-rs/security/dependabot/21.

@mmalenic mmalenic enabled auto-merge September 30, 2024 05:11
@mmalenic mmalenic added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit e26dde1 Sep 30, 2024
5 checks passed
@mmalenic mmalenic deleted the feat/c4gh-all-storage branch September 30, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brainstorm brainstorm brainstorm approved these changes

Assignees

@mmalenic mmalenic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalenic @brainstorm