Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several deps bump: Actix, Tokio, Rustls, AWS SDK et al #237

Merged
merged 10 commits into from
May 22, 2024
Merged

Several deps bump: Actix, Tokio, Rustls, AWS SDK et al #237

merged 10 commits into from
May 22, 2024

Conversation

brainstorm
Copy link
Member

No description provided.

brainstorm and others added 10 commits March 28, 2024 12:58
@brainstorm
Bunch of breakage after bumps
16f44da
@brainstorm
Apply changelog recomendations from rustls 0.22.0: https://github.com…
8533345 
…/rustls/rustls/releases/tag/v%2F0.22.0 ... regarding PrivateKey(Der) and Certificate(Der), from the new rustls-pki-types crate
@brainstorm
Bump it all
c299c98
@brainstorm
More changes in rustls upstream, i.e RSA is deprecated for good, many…
58fecd1 
… types, methods and results have changed
@brainstorm
Fix rustls-related migration issues, a few more remaining, might obli…
733daec 
…terate tls.rs if the upstream API provives the methods we need with the right types, wip
@brainstorm
Nightmarish rustls tls wrapper api update, continued
222cbed
@brainstorm
SerDe's tryfrom annotation is preventing async'ing the rest of the tl…
4421342 
…s.rs methods
@brainstorm
[ci skip] Rustls file-less (stream-only) refactor proving more comple…
bd7de6a 
…x than I expected...
@mmalenic
Merge branch 'main' of https://github.com/umccr/htsget-rs into mio_h2…
b697054 
…_bump
@mmalenic
build: major dep updates, rustls 0.21 -> 0.23, http 0.2 -> 1, reqwest…
7cce691 
… 0.11 -> 0.12, noodles 0.65 -> 0.74 + minor bumps for other crates depending on these.
mmalenic
mmalenic reviewed May 21, 2024
View reviewed changes
Copy link
Member

@mmalenic mmalenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think I've gotten all dep bumps. Wasn't as bad as I thought once I realised rustls_pemfile was doing pretty much the same thing as before.

htsget-actix/src/handlers/mod.rs Show resolved Hide resolved
htsget-config/src/tls/mod.rs Show resolved Hide resolved
@mmalenic mmalenic marked this pull request as ready for review May 21, 2024 09:33
@mmalenic
Copy link
Member

@brainstorm I would request your review but I can't since it's your PR.

brainstorm
brainstorm commented May 22, 2024
View reviewed changes
Copy link
Member Author

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @mmalenic, you didn't even need to touch tls.rs :-!

htsget-config/src/tls/mod.rs Show resolved Hide resolved
htsget-search/src/storage/data_server.rs Show resolved Hide resolved
@brainstorm brainstorm requested a review from mmalenic May 22, 2024 01:12
@brainstorm brainstorm enabled auto-merge May 22, 2024 01:12
@brainstorm
Copy link
Member Author

brainstorm commented May 22, 2024 •
edited
Loading

@brainstorm I would request your review but I can't since it's your PR.

I cannot approve my own PR, lol... so you'll have to approve it for the merge to go forward (all other boxes are ticked now).

@brainstorm brainstorm added this pull request to the merge queue May 22, 2024
Merged via the queue into main with commit 684a3c0 May 22, 2024
5 checks passed
@brainstorm brainstorm deleted the mio_h2_bump branch May 22, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalenic mmalenic mmalenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brainstorm @mmalenic