Skip to content

Commit

Permalink
refactor: startDate 삭제
Browse files Browse the repository at this point in the history
  • Loading branch information
junseokkim committed Jan 2, 2024
1 parent a46090b commit 44be66b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ public class CalendarController {

@PostMapping
@Operation(summary = "캘린더 생성 API")
public ApiResponse<CalendarMissionsResponse> createCalendar(@RequestParam Long memberId, @RequestParam LocalDate startDate) {
return ApiResponse.onSuccess(calendarService.createCalendar(memberId, startDate));
public ApiResponse<CalendarMissionsResponse> createCalendar(@RequestParam Long memberId) {
return ApiResponse.onSuccess(calendarService.createCalendar(memberId));
}

@GetMapping
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@
@AllArgsConstructor
public class CalendarMissionsResponse {
private Long calenderId;
private String nickname;
private List<CalendarMissionResponse> missions;
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ public CalendarMission toCalendarMission(String content, LocalDate date, boolean
.build();
}

public CalendarMissionsResponse toCalendarMissionsResponse(Calendar calendar, List<CalendarMissionResponse> missionResponses) {
return new CalendarMissionsResponse(calendar.getId(), missionResponses);
public CalendarMissionsResponse toCalendarMissionsResponse(Member member, Calendar calendar, List<CalendarMissionResponse> missionResponses) {
return new CalendarMissionsResponse(calendar.getId(), member.getNickname(), missionResponses);
}

public List<CalendarMissionResponse> toCalendarMissionResponseList(List<CalendarMission> missions) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public class CalendarService {
private final RewardService rewardService;

@Transactional
public CalendarMissionsResponse createCalendar(Long memberId, LocalDate startDate) {
public CalendarMissionsResponse createCalendar(Long memberId) {
Member loginUser = memberService.findMemberById(memberId);

// 이전 캘린더가 다 수행되지 않았을 경우 예외 처리
Expand All @@ -47,7 +47,7 @@ public CalendarMissionsResponse createCalendar(Long memberId, LocalDate startDat
// 캘린더 내의 모든 미션들 생성
try {
List<NewMissionResponse> missions = missionService.generateMission();
return calendarMapper.toCalendarMissionsResponse(newCalendar, toCalendarMissionsResponse(missions, newCalendar));
return calendarMapper.toCalendarMissionsResponse(loginUser, newCalendar, toCalendarMissionsResponse(loginUser, missions, newCalendar));

} catch (Exception e) {
throw new ExceptionHandler(ErrorStatus.CREATE_MISSION_FAILED);
Expand All @@ -64,7 +64,7 @@ public CalendarMissionsResponse getCalendar(Long memberId) {
}

List<CalendarMission> missions = calendarMissionRepository.findAllByCalendarOrderByDate(calendar.get());
return calendarMapper.toCalendarMissionsResponse(calendar.get(), calendarMapper.toCalendarMissionResponseList(missions));
return calendarMapper.toCalendarMissionsResponse(loginUser, calendar.get(), calendarMapper.toCalendarMissionResponseList(missions));
}

@Transactional
Expand All @@ -87,7 +87,7 @@ public CalendarMissionIdResponse completeMission(Long memberId, Long missionId)
return new CalendarMissionIdResponse(calendarMission.getId());
}

private List<CalendarMissionResponse> toCalendarMissionsResponse(List<NewMissionResponse> missions, Calendar calendar) {
private List<CalendarMissionResponse> toCalendarMissionsResponse(Member member, List<NewMissionResponse> missions, Calendar calendar) {
LocalDate now = LocalDate.now();
List<CalendarMissionResponse> calendarMissions = new ArrayList<>();
for(int i = 0; i < 30;i++) {
Expand Down

0 comments on commit 44be66b

Please sign in to comment.