Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: no callback then destroy #17943

Open
wants to merge 1 commit into
base: v15/dev
Choose a base branch
from

destroy if observer has no callback

80e9402
Select commit
Loading
Failed to load commit list.
Open

Feature: no callback then destroy #17943

destroy if observer has no callback
80e9402
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/dev) succeeded Jan 10, 2025 in 35s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.16 (10.00 -> 9.84)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Bumpy Road Ahead observer.ts: UmbObserver.asPromise

Annotations

Check warning on line 47 in src/Umbraco.Web.UI.Client/src/libs/observable-api/observer.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/dev)

❌ New issue: Bumpy Road Ahead 

UmbObserver.asPromise has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
View more details on CodeScene Delta Analysis