V15: Handle domains in invariant content #17937
Open
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyButland
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where domains was broken for invariant content, given the following setup
/enwith English culture/dawith Danish cultureYou would expect that the URLs return by
Url()to be/da/for the danish root, and/da/text-da/for the danish child, however this was not the case, and it would instead return the "default" URLThe reason for this is that
GetLegacyRouteFormatwould always look for a domain with the passed in culture, however this doesn't make sense in an invariant setup like this, since the culture will always be null, and we'll never find any domains.We can see that similar logic was applied in
DomainCacheExtensions.GetAssignedWithCulturein the old routing systemTesting
Create a setup like above and check that URLs are generated correctly.
This template is a helpful way of doing so:
@inherits Umbraco.Cms.Web.Common.Views.UmbracoViewPage @{ Layout = null; var descendants = Model.DescendantsOrSelf(); } <html lang="en"> <body> <h1>@Model.Name</h1> <ul> @foreach (var desc in descendants) { <li>@desc.Name - @desc.Url()</li> } </ul> </body> </html>