-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves issues related to the setting of a schedule for content publishing #17868
base: v15/dev
Are you sure you want to change the base?
Conversation
# Conflicts: # src/Umbraco.Cms.Api.Management/Controllers/Document/ByKeyDocumentController.cs # src/Umbraco.Cms.Api.Management/Factories/IDocumentPresentationFactory.cs # src/Umbraco.Cms.Api.Management/ViewModels/Document/DocumentVariantResponseModel.cs # src/Umbraco.Core/Services/ContentPublishingService.cs # src/Umbraco.Web.UI.Client/src/packages/core/workspace/conditions/manifests.ts # src/Umbraco.Web.UI.Client/src/packages/core/workspace/conditions/types.ts # src/Umbraco.Web.UI.Client/src/packages/documents/documents/publishing/publish-with-descendants/workspace-action/manifests.ts
I've combined this with the work @Migaroez did in #17535, as we'd overlapped slightly. Have picked out his updates and ensured they worked with mine in the UI. It's working a lot better now in terms of saving a schedule and having it displayed in the UI again so you can view and edit it. The only issue I can still see is for variant content, in that when you view or set the schedule, you don't see the previous schedule of the non-active variant. E.g. here I'm looking at English and have clicked the Schedule button: Which correctly shows the previously set English schedule and has the Italian one hidden. But if I click to view or set the Italian one, I don't see the previously set schedule: It's OK though if I've made a change to the Italian content. I can kind of see why... but it seems that this dialog has really been built around displaying data for the active or changed variants. Here that doesn't seem right - seems we should be able to see and set a schedule for a non-active and non-changed variant, |
Prerequisites
Addresses issues raised in #17031, tracked under AB 45476 (internal HQ tracker)
Also #17830 tracked under AB 47430
Description
Reported issue:
#17031 describes several issues related to the setting and reading of scheduled publishing details:
Resolution:
With the PR merged, these issues will be addressed as follows:
To Test:
umbracoContentSchedule
), which will indicate that issue 5 is resolved.