New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to send an email with a LinkedResource #17863

Open

Stanislaw-Rudnicki wants to merge 2 commits into umbraco:contrib from Stanislaw-Rudnicki:temp/Add-the-ability-to-send-an-email-with-a-LinkedResource

+40 −3

Open

Add the ability to send an email with a LinkedResource #17863

Add the ability to send an email with a LinkedResource

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Dec 24, 2024 in 32s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.19 (9.88 -> 9.69)

Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

Complex Method EmailMessageExtensions.cs: ToMimeMessage

Annotations

Check notice on line 35 in src/Umbraco.Core/Models/Email/EmailMessage.cs

codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

ℹ Getting worse: Constructor Over-Injection

EmailMessage increases from 9 to 10 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.

Check warning on line 48 in src/Umbraco.Infrastructure/Extensions/EmailMessageExtensions.cs

codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

❌ New issue: Complex Method

ToMimeMessage has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

View more details on CodeScene Delta Analysis