Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13 QA updated locator for failing E2E test #17825

Merged
merged 5 commits into from
Jan 14, 2025

Merge branch 'release/13.6' into v13/QA/fix-failing-test

4851bb9
Select commit
Loading
Failed to load commit list.
Merged

V13 QA updated locator for failing E2E test #17825

Merge branch 'release/13.6' into v13/QA/fix-failing-test
4851bb9
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (release/13.6) failed Jan 8, 2025 in 34s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.00 (8.53 -> 8.52)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method blockGridEditorContent.spec.ts: 'BlockGridEditorContent'.'Moving blocks'

Annotations

Check warning on line 235 in tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/BlockGridEditor/Content/blockGridEditorContent.spec.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (release/13.6)

❌ Getting worse: Large Method 

'BlockGridEditorContent'.'Moving blocks' increases from 90 to 91 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis