Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds our-self-host #47

Merged
merged 5 commits into from
May 12, 2023
Merged

Adds our-self-host #47

merged 5 commits into from
May 12, 2023

Conversation

skttl
Copy link
Contributor

@skttl skttl commented Dec 4, 2022 •
edited by warrenbuckley
Loading

@warrenbuckley
Copy link
Member

@skttl just read blog post, mind fixing up the small conflict then can get this merged in :)

@skttl skttl marked this pull request as ready for review December 8, 2022 10:57
@warrenbuckley warrenbuckley added the enhancement New feature or request label Dec 8, 2022
@warrenbuckley
Copy link
Member

Generally, looks all OK to me @skttl - just see the two small remarks.
Also do you think it's worth adding tests for this as well in the test project ?

@skttl
Copy link
Contributor Author

skttl commented May 10, 2023

Added some tests, and fixed a bug - all good now :)

@warrenbuckley
Copy link
Member

All good, sorry I took so long to get it merged @skttl 🙈

@warrenbuckley warrenbuckley merged commit 7e23b3a into umbraco-community:main May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrenbuckley warrenbuckley warrenbuckley left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skttl @warrenbuckley