NOISSUE - Create and publish a Docker image #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new file `.github/workflows/build.yml` which contains the workflow configuration for creating and publishing a Docker image. The workflow is triggered on push events to the `main` branch. It sets environment variables for the registry and image name. The job runs on `ubuntu-latest` and has necessary permissions for reading contents and writing packages. The steps include checking out the repository, logging in to the container registry using the GitHub token, and extracting metadata for Docker. Signed-off-by: SammyOina <[email protected]>
dborovcanin
approved these changes
Dec 20, 2023
dborovcanin
requested changes
Dec 20, 2023
The build workflow has been refactored to build the Manager image instead of the API Gateway image. The Makefile has also been updated. The changes include: - Renaming the build step to "Build Manager and push Docker image" - Updating the image name to include "/manager" - Updating the build arguments to use "SVC=manager" - Updating the tags to use the output from the metadata action These changes ensure that the correct Docker image is built and pushed. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
dborovcanin
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add workflow to publish images to ghcr