refactor to simply code using Mime struct and mime_guess crate #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor utils to use mime and mime_guess crates refactor Document fn write_html to use mime_guess (plus a few tests!) - PathExt use mime_guess to return mime type from a path - Document::write_html - use mime_guess directly since CowStr url not a Path - match on structured mime type - delete unused utility functions
|
addresses #26 |
not comprehensive, just making testing that library is wired up correctly if more bugs are found, likely tests needed in some dependent library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor utils to use mime and mime_guess crates
refactor Document fn write_html to use mime_guess (plus a few tests!)
TODO: