Link checks SSL insecure robustness #550
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request updates the GitHub Actions workflow for checking broken links by refining the list of ignored status codes and improving the robustness of the link checking process. It also updates the checkout action version and modifies the cron schedule syntax.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.
General suggestions:
- Ensure that the use of the
--insecureflag is justified and well-documented to avoid potential security risks. - Consider the impact of increased
max_attemptson the CI run time and adjust if necessary to balance resilience with efficiency. - Review the consistency of the
--acceptflag across different commands to ensure that the intended status codes are being handled correctly in all scenarios.
Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨
| lychee \ | ||
| --scheme 'https' \ | ||
| --timeout 60 \ | ||
| --insecure \ |
There was a problem hiding this comment.
issue (llm): Using the --insecure flag may expose the CI process to security vulnerabilities by allowing insecure server connections when fetching URLs. If this is necessary for internal URLs or known exceptions, consider documenting the reason to ensure future maintainers understand the risk.
| --scheme 'https' \ | ||
| --timeout 60 \ | ||
| --insecure \ | ||
| --accept 429,999 \ |
There was a problem hiding this comment.
issue (llm): The --accept flag for the retry command does not include the additional status codes (403, 500, 502) that were added to the initial link check command. If these status codes should also be ignored on retry, they need to be included here as well.
No description provided.