Merge pull request #38 from lonemeow/histogram-cardinality

Allow setting max cardinality for histograms
ultrabrew · Feb 18, 2021 · c251e99 · c251e99
2 parents 60cc8e4 + 4b507f1
commit c251e99
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/core/src/main/java/io/ultrabrew/metrics/reporters/TimeWindowReporter.java b/core/src/main/java/io/ultrabrew/metrics/reporters/TimeWindowReporter.java
@@ -4,6 +4,7 @@
 
 package io.ultrabrew.metrics.reporters;
 
+import static io.ultrabrew.metrics.Metric.DEFAULT_MAX_CARDINALITY;
 import static io.ultrabrew.metrics.reporters.AggregatingReporter.DEFAULT_AGGREGATORS;
 
 import io.ultrabrew.metrics.Metric;
@@ -191,13 +192,24 @@ public B withDefaultAggregators(
      *
      * @param metricId identifier of the metric
      * @param bucket distribution bucket
+     * @param maxCardinality maximum cardinality of data in the histogram
      */
-    public B addHistogram(final String metricId, final DistributionBucket bucket) {
+    public B addHistogram(final String metricId, final DistributionBucket bucket, final int maxCardinality) {
       this.metricAggregators
-          .put(metricId, (metric) -> new BasicHistogramAggregator(metricId, bucket));
+          .put(metricId, (metric) -> new BasicHistogramAggregator(metricId, bucket, maxCardinality));
       return (B) this;
     }
 
+      /**
+       * Add histograms to a specific metric
+       *
+       * @param metricId identifier of the metric
+       * @param bucket distribution bucket
+       */
+    public B addHistogram(final String metricId, final DistributionBucket bucket) {
+      return addHistogram(metricId, bucket, DEFAULT_MAX_CARDINALITY);
+    }
+
     public abstract R build();
 
   }