Initialize variables to avoid segfault. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we call 'keystone_end' right after 'keystone_start' segfault occurs. It's clear that it's not expected user behavior, but possible segfaults should be avoided.
Code was obsolete - last commit was 4 yesrs ago. Request and response formats were changed since then. Also added small test to check obtaining of token. Also added brief howto in readme.
Dmitry-Eremeev
force-pushed
the
master
branch
from
769b339 to
5a44c54
Compare
KSTEST_ADMIN_URL = http://192.168.122.216/identity/v3/auth/tokens OS_PROJECT_NAME = admin KSTEST_ADMIN_USERNAME = admin KSTEST_ADMIN_PASSWORD = secret
All methods are obsolete and have no use. So removed them. The only operation method is getting token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we call 'keystone_end' right after 'keystone_start'
segfault occurs.
It's clear that it's not expected user behavior,
but possible segfaults should be avoided.