Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix missing tag for SSM parameter EGRESS_IP #349

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

tony-griffin
Copy link
Contributor

@tony-griffin tony-griffin commented Feb 27, 2025

Ad-hoc quick fix

The demodjango-deploy/copilot/{service}/overrides/cfn.patches.yml file grants the service access to the SSM params that have the tag:

copilot-application': '__all__'

We need to add that tag to the EGRESS_IP SSM param in order for the copilot/{service}/manifest.yml to use the SSM parameter.

Each time an environment gets re-provisoned it was wiping the manually added tag and this breaks the codebase pipeline as thew web service depends on the EGRESS_IP SSM param

Deployment failure logs


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@tony-griffin tony-griffin requested a review from a team as a code owner February 27, 2025 15:09
@tony-griffin tony-griffin changed the title chore: Fix missing SSM tag chore: Fix missing tag for SSM parameter EGRESS_IP Feb 27, 2025
@tony-griffin tony-griffin requested review from a team and removed request for a team February 27, 2025 15:34
@WillGibson WillGibson changed the title chore: Fix missing tag for SSM parameter EGRESS_IP fix: Fix missing tag for SSM parameter EGRESS_IP Feb 27, 2025
Copy link
Contributor

@WillGibson WillGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the scope to fix, because that's what it is, and (I think) chore does not get included in release notes.

@tony-griffin tony-griffin merged commit 8483746 into main Feb 28, 2025
71 checks passed
@tony-griffin tony-griffin deleted the fix-missing-ssm-tag branch February 28, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants